Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Improve Russian (ru-RU) locale #11210

Conversation

dastan-akhmetov-scity
Copy link
Contributor

@dastan-akhmetov-scity dastan-akhmetov-scity commented Nov 27, 2023

@mui-bot
Copy link

mui-bot commented Nov 27, 2023

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-11210--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 1d000ea

@dastan-akhmetov-scity dastan-akhmetov-scity changed the title [locales] Use count for russian in footer row selected [l10n] Improve Russian (ru-RU) locale Nov 27, 2023
@zannager zannager added the l10n localization label Nov 27, 2023
dastan-akhmetov-scity added a commit to dastan-akhmetov-scity/mui-x that referenced this pull request Nov 27, 2023
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Nov 28, 2023
@michelengelen
Copy link
Member

@cherniavskii do you know if this change makes sense?

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@flaviendelangle
Copy link
Member

@cherniavskii we could probably move on with this one

@MBilalShafi MBilalShafi changed the base branch from next to master March 21, 2024 02:32
@MBilalShafi
Copy link
Member

Hey @dastan-akhmetov-scity Could you rebase with the latest master branch to resolve the conflicts?
Thanks

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 25, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented May 25, 2024

I have tried to fix the PR. Using this code to check accuracy:

var cardinalRules = new Intl.PluralRules("ru-RU")
Array.from(new Array(50)).map((x, index) => cardinalRules.select(index))
SCR-20240525-rajt

The logic is still not right IMHO, but it feels like a good enough step forward for this PR. What I would explore more of:

  1. Fix the number formatting, point 1 in [data grid] Format row count numbers in pagination #13222 (comment).
  2. Make sure everything is translated what [data grid] Format row count numbers in pagination #13222 is about initially
  3. Consider using Intl.PluralRules over a manual logic (maybe it doesn't matter though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants